[wp-trac] [WordPress Trac] #15015: Customisable submit button for comment form

[WordPress Trac]

#15015: Customisable submit button for comment form
------------------------------------+-----------------------
 Reporter:  morpheu5                |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  4.2
Component:  Comments                |     Version:  3.0.1
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |     Focuses:  template
------------------------------------+-----------------------
Changes (by boonebgorges):

 * keywords:  dev-feedback has-patch commit => dev-feedback has-patch


Comment:

 Patch looks good, but I have a question about the markup. The submit
 button is wrapped in `<p class="form-submit">`. It seems odd to include
 this markup as part of an argument called 'submit_button'. Putting it
 there also means moving the `comment_id_fields()` call to outside the
 `<p>` element - a change that looks harmless, but could cause problems if
 someone is expecting those fields in a certain place in the DOM. What do
 you think of removing the `<p>` tag from 'submit_button' and hardcoding
 it, like it is currently? Or maybe introducing two new arguments:
 'submit_button', and 'submit_field', which would be something like `<p
 class="form-submit">%1$s %2$s</p>` (1: button, 2: id fields)? Am I being
 paranoid? :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/15015#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform