[wp-trac] [WordPress Trac] #31495: Always use 'login' as $scheme parameter for "login-ish" URLs, and other inconsistencies

[WordPress Trac]

#31495: Always use 'login' as $scheme parameter for "login-ish" URLs, and other
inconsistencies
------------------------------------+------------------------------
 Reporter:  GregLone                |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Login and Registration  |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:                          |     Focuses:
------------------------------------+------------------------------

Comment (by GregLone):

 In 31495.patch:
 '''wp-activate.php''':
 - Use `wp_registration_url()` for redirection instead of `site_url( '/wp-
 login.php?action=register' )`.
 - Use `switch_to_blog()` + `wp_login_url()` + `restore_current_blog()`
 instead of `$url . 'wp-login.php'`.
 '''wp-signup.php''':
 - Use `wp_registration_url()` for redirection instead of `site_url( 'wp-
 login.php?action=register' )`.
 - In `validate_another_blog_signup()`, use the blog ID returned by
 `wpmu_create_blog()` and pass it to `confirm_another_blog_signup()`. In
 `confirm_another_blog_signup()`, use the new parameter `$blog_id` to get
 the login URL. Also removed two unused parameters `$user_email` and
 `$meta`.
 - Use `wp_login_url( network_site_url( 'wp-signup.php' ) )` instead of
 `site_url( 'wp-login.php?redirect_to=' . urlencode( network_site_url( 'wp-
 signup.php' ) ) )`.
 '''wp-admin/install.php''':
 - Use `esc_url( wp_login_url() )` instead of `href="../wp-login.php"`.
 '''wp-admin/network.php''':
 - Use `esc_url( wp_login_url() )` instead of `esc_url( site_url( 'wp-
 login.php' ) )`.
 '''wp-includes/canonical.php''':
 - Use `wp_registration_url()` for redirection instead of `site_url( 'wp-
 login.php?action=register' )`.
 - Use `wp_login_url()` for redirection instead of `site_url( 'wp-
 login.php', 'login' )`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31495#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform