[wp-trac] [WordPress Trac] #15928: wp_get_attachment_url does not check for HTTPS

[WordPress Trac]

#15928: wp_get_attachment_url does not check for HTTPS
--------------------------+-----------------------------
 Reporter:  atetlaw       |       Owner:  boonebgorges
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  Future Release
Component:  Permalinks    |     Version:  3.0.3
 Severity:  major         |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------------

Comment (by joemcgill):

 Hey Boone – after getting some time to review the original logic of this
 patch, I believe the reason I was checking to make sure the attachment's
 URL scheme matched the scheme of the `wp_upload_dir()`, rather than simply
 checking for an `http://` scheme, is because a site which has its public
 url set to an `https://` scheme would still produce `https://` attachment
 urls with this patch, even when the site front is being accessed from a
 non-SSL url. In those cases, we're not forcing attachments into `http://`
 schemes with this change.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/15928#comment:95>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform