[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General

[WordPress Trac]

#16434: Give site admin ability to upload favicon in Settings, General
--------------------------+------------------------------------------------
 Reporter:  jane          |       Owner:  obenland
     Type:  task          |      Status:  accepted
  (blessed)               |   Milestone:  4.3
 Priority:  normal        |     Version:  3.1
Component:  Customize     |  Resolution:
 Severity:  normal        |     Focuses:  ui, accessibility, administration
 Keywords:  ux-feedback   |
  has-patch               |
--------------------------+------------------------------------------------

Comment (by obenland):

 Replying to [comment:194 jipmoors]:
 > When an image with specified dimensions has been selected (512x512 on
 default settings) do we want to generate a new file with the same
 dimensions or just use that file? When removing the site-icon you probably
 don't want to remove that file so a new file seems logical but still looks
 strange in the media library.

 Yes, new file. In the media library it get's a `Site Icon` label (in the
 list view) to give it context. I believe that's missing in grid view, but
 that shouldn't be too bad.

 > Also, when selecting this file we want to skip the crop page, but since
 that is being loaded after the media-selector the headers have already
 been sent at the `crop_page` function. This only leaves an option to
 javascript-submit the form to go to the next step, or am I missing
 something?

 We can use the `admin_action_crop_site_icon` action to check the image and
 redirect.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/16434#comment:195>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform