[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General

[WordPress Trac]

#16434: Give site admin ability to upload favicon in Settings, General
--------------------------+------------------------------------------------
 Reporter:  jane          |       Owner:  obenland
     Type:  task          |      Status:  accepted
  (blessed)               |   Milestone:  4.3
 Priority:  normal        |     Version:  3.1
Component:  Customize     |  Resolution:
 Severity:  normal        |     Focuses:  ui, accessibility, administration
 Keywords:  ux-feedback   |
  has-patch               |
--------------------------+------------------------------------------------

Comment (by boonebgorges):

 [32994] broke a unit test:
 `Tests_Post_GetPostClass::test_taxonomy_classes_hit_cache()`. The test
 references `$wpdb->num_queries`, and [32994] adds a query to the
 `get_post_class()` chain. Specifically, the
 `WP_Site_Icon::get_post_metadata()` callback is fired, which results in a
 call to `get_option( 'site_icon' )`. Both of these facts are unique to the
 automated tests: normally, the `get_post_metadata` callback will only be
 fired in the admin, and normally it will be cached, and the test suite is
 an outlier in these ways.

 These query-counting tests are pretty fragile, so it's no big deal to
 increment the count in the test.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/16434#comment:189>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform