[wp-trac] [WordPress Trac] #32819: Customizer: the Collapse sidebar link should be a button

[WordPress Trac]

#32819: Customizer: the Collapse sidebar link should be a button
--------------------------+--------------------------------------------
 Reporter:  afercia       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Customize     |     Version:  4.2
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  ui, accessibility, javascript
--------------------------+--------------------------------------------
Changes (by afercia):

 * keywords:   => has-patch


Comment:

 First pass.
 - remove the title attribute
 - add `aria-expanded` and `aria-label` attributes to be dynamically
 updated depending on the sidebar status
 - tries to simplify CSS
 - use the focus style proposed in #31201 props to @jk2228

 Tested on latest Chrome and Firefox on Windows and in IE 8. Needs testing
 on modern IE, Safari, Macs.

 Screenshots in different states, before and after. Notice in Firefox on
 Windows the arrow CSS transform doesn't get sub-pixel anti-aliasing, fixed
 in the patch with the `.001deg` hack.

 [[Image(https://cldup.com/nz8duIpl9C.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32819#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform