[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General

[WordPress Trac]

#16434: Give site admin ability to upload favicon in Settings, General
-------------------------------------------------+-------------------------
 Reporter:  jane                                 |       Owner:
     Type:  task (blessed)                       |  johnbillion
 Priority:  normal                               |      Status:  accepted
Component:  Customize                            |   Milestone:  4.3
 Severity:  normal                               |     Version:  3.1
 Keywords:  ux-feedback needs-patch needs-       |  Resolution:
  screenshots                                    |     Focuses:  ui,
                                                 |  administration
-------------------------------------------------+-------------------------

Comment (by tyxla):

 The last patch I have submitted addresses some of the no-JS issues as
 reported by @jancbeck:

 1. The edit/remove link buttons will now appear as regular separate
 buttons
 2. The Crop and Publish button will now appear as just Publish when JS is
 disabled. This will avoid misleading the user, having the crop step
 appearing as a preview step before the user actually saves the icon.

 Concerning the favicon previews missing `max-width:100%`, I think that it
 would not achieve the expected result. If the user uploads a rectangle
 images, they will receive a non-square preview there, which would mislead
 them about the end result.

 I confirm the rest of the issues.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/16434#comment:177>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform