[wp-trac] [WordPress Trac] #32781: Customizer Menus: Debug Notices

[WordPress Trac]

#32781: Customizer Menus: Debug Notices
------------------------------------+--------------------
 Reporter:  johnjamesjacoby         |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  4.3
Component:  Customize               |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+--------------------

Comment (by SergeyBiryukov):

 Replying to [comment:1 johnjamesjacoby]:
 > Currently in `wp_nav_menu()`, all object variables are assumed to be at
 least set. I see two potential fixes:
 >
 > * Change the `unset()`'s in
 `WP_Customize_Nav_Menus::filter_wp_nav_menu_args();` to empty strings so
 they remain set
 > * Wrap all object variable checks in `wp_nav_menu()` in `isset()` or `!
 empty()` to avoid notices

 I think I'd prefer the first option in this ticket's scope.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32781#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform