[wp-trac] [WordPress Trac] #32760: Customizer Menus: cannot save a menu with the same name as an existing menu

[WordPress Trac]

#32760: Customizer Menus: cannot save a menu with the same name as an existing menu
-------------------------------------+--------------------------
 Reporter:  designsimply             |       Owner:  westonruter
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  4.3
Component:  Customize                |     Version:  trunk
 Severity:  major                    |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  javascript
-------------------------------------+--------------------------
Changes (by westonruter):

 * keywords:  needs-patch => has-patch needs-testing


Comment:

 OK, [attachment:32760.diff] fixes the issue:

 * When saving a nav menu, the name is checked for conflicts with existing
 menus and a number is appended. The conflict-resolved name is used in the
 UI when the Customizer finishes saving.
 * Empty names are prevented by forcing the value "(unnamed)" to be used
 instead.
 * Fixed an issue where setting `save()` errors weren't resulting in their
 errors short-circuiting the logic flow.

 @designsimply: Please test.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32760#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform