[wp-trac] [WordPress Trac] #32531: Media library filename based on GUID prevents embedding

[WordPress Trac]

#32531: Media library filename based on GUID prevents embedding
--------------------------+---------------------------------
 Reporter:  daxelrod      |       Owner:  wonderboymusic
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.3
Component:  Media         |     Version:  4.1
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |     Focuses:  ui, administration
--------------------------+---------------------------------
Changes (by wonderboymusic):

 * owner:   => wonderboymusic
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"32914"]:
 {{{
 #!CommitTicketReference repository="" revision="32914"
 In `wp_prepare_attachment_for_js()`, when setting `filename`, call
 `wp_basename()` on the result of `get_attached_file()`, not
 `WP_Post->guid`. `guid` can be set to the result `get_permalink()`, which
 is not a file path.

 Props daxelrod.
 Fixes #32531.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32531#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform