[wp-trac] [WordPress Trac] #27959: get_uploaded_header_images(); should provide alternate text of that image

WordPress Trac noreply at wordpress.org
Tue Jun 23 09:05:04 UTC 2015


#27959: get_uploaded_header_images(); should provide alternate text of that image
----------------------------+---------------------------
 Reporter:  francoeurdavid  |       Owner:  valendesigns
     Type:  enhancement     |      Status:  assigned
 Priority:  normal          |   Milestone:  4.3
Component:  Customize       |     Version:  3.2
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  template
----------------------------+---------------------------

Comment (by obenland):

 Replying to [comment:14 valendesigns]:
 > @obenland I think that this patch should remain as is and not change
 other parts of Core. This is more for convenience and would give theme
 authors access to the alt text by default.

 I think we should check for the alt text
 [https://core.trac.wordpress.org/browser/tags/4.2.2/src/wp-admin/custom-
 header.php#L279 here] and make description the fallback, like it's done
 [https://core.trac.wordpress.org/browser/tags/4.2.2/src/wp-includes/class-
 wp-customize-control.php#L1084 in the customizer].
 >
 > Though I think after looking at other parts of Core the array key should
 be set to `alt_text` instead of `alt`, which is what the
 `get_uploaded_header_images()` method in the `Custom_Image_Header` class
 uses. I can upload another patch but wanted to get your opinion first.

 No objections to `alt_text`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27959#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list