[wp-trac] [WordPress Trac] #29906: Submenus can't be dismissed on mobile.

[WordPress Trac]

#29906: Submenus can't be dismissed on mobile.
-------------------------------------------------+-------------------------
 Reporter:  obenland                             |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  high                                 |   Milestone:  4.3
Component:  Toolbar                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  make-flow has-patch needs-testing    |     Focuses:
  desktop-bias                                   |
-------------------------------------------------+-------------------------

Comment (by seanchayes):

 I looked at the original reported issue using 4.3-alpha-32280.

 The issue is slight more prevalent on landscape compared to portrait on
 either Android or iOS due to the amount of screen real estate occupied by
 the submenu.

 The screenshot originally provided shows the issue best and the ticket
 mentions there's no way to dismiss the site-name submenu without ending up
 at an admin screen. The site-name parent navigation item is a link so
 tapping it again and having the link followed I would think is expected
 behavior. Tapping somewhere else that is not on the site-name navigation
 menu should dismiss the submenu.

 In landscape, based on the screenshot and some tested I've been able to
 perform on an iPhone and and Android truly there was no where to tap that
 would just remove the submenu or dismiss it. In portrait there is often
 enough screen real estate to allow for a tap/click

 With that in mind I applied '''29906.4''' and oriented my devices in
 landscape and concur that there are double taps in some circumstances.

 1. Tapping to make the site-name submenu appear works and immediately
 tapping the site-name logo removes the dropdown and does not follow its
 related link. Meets the needs of the ticket description.
 2. Tapping to make the site-name submenu appear works and tapping any area
 on on the admin bar prior to tapping the site-name to remove it the
 requires a second tap on the site-name logo before the submenu is removed.
 Once the submenu is removed, any further taps on the admin bar prior to
 tapping the site-name logo still require an additional tap on the site-
 name logo before the submenu is displayed. On iOS a flicker is present on
 the admin bar when tapping a blank space. Side effect requiring additional
 taps to progress.
 3. After tapping to make the site-name submenu appear you can tap, hold
 and drag the submenu to reveal the body of the page and if you then tap in
 the body of the page the submenu is removed. Mimicking current behavior.
 4. On both iOS and Android tapping a blank area on the admin bar doesn't
 dismiss the submenu. Mimicking current behavior.

 (1 & 2 the focus color is retained on the site-name logo until you tap
 elsewhere within the display. For 3. the focus color is removed)
 A side effect is that tapping a top level menu item like the site-name
 logo, the profile/avatar top level menu or the "plus" doesn't follow the
 link present in those items. So you can't get to those links.

 I reviewed my patch '''29906-2''' and applied that repeating the tests
 above.

 1. Tap, submenu appears, tap again and the link is followed mimicking
 current behavior.
 2. Tap, submenu appears, tap elsewhere on the admin bar the submenu is
 dismissed - new behavior and meeting the needs of the ticket
 3. Same behavior. Mimicking current behavior.
 4. Active submenu is dismissed. Meets the needs of the ticket description

 I didn't encounter any double taps although previously "eaten taps" were
 reported when 29906-2 was applied - I didn't encounter "eaten taps".

 We've previously discussed / commented on the results of the tapping
 action on the top level menu item - should it just dismiss the menu or
 follow the link built into it. I think that's an important distinction /
 decision and could be addressed perhaps by reviewing the mobile navigation
 as a whole perhaps but not addressed or changed as a result of code in
 this ticket. We did cover that in the '''-comment15''' portion of this
 ticket with some sample code.

 Aside from that the submenu can be more easily dismissed by allowing the
 user to tap elsewhere on the admin bar to dismiss a submenu compared to
 actions required prior to the patch

 However, I think with minor caveats each, between '''29906-2''' and
 '''29906.4''' we should have an acceptable solution for this ticket this
 time around.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29906#comment:61>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform