[wp-trac] [WordPress Trac] #29906: Submenus can't be dismissed on mobile.

[WordPress Trac]

#29906: Submenus can't be dismissed on mobile.
-------------------------------------------------+-------------------------
 Reporter:  obenland                             |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  high                                 |   Milestone:  4.3
Component:  Toolbar                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  make-flow has-patch needs-testing    |     Focuses:
  needs-refresh desktop-bias                     |
-------------------------------------------------+-------------------------

Comment (by stephdau):

 [attachment:29906.4.diff] has better targeting and uses `.not(.mobile)`
 (CSS3) to make sure the icon's highlight background and color are cleared
 when clicking to close on mobile. This is because the element still gets
 `:focus()` and `:hover()` on click.

 What remains is to clear the blue color on the icon still applied through
 `:before` after the rest is handled. This is actually a long standing bug,
 as the "hamburger menu" icon suffers from the same issue regardless of
 this work.

 To fix this, we'll have to deal with the same (`:focus` and `:hover`) in
 this monster, which I could help with, in admin-bar.css, likely through a
 combination of ignoring/including `.mobile` vs `.hover`:
 https://core.trac.wordpress.org/browser/trunk/src/wp-includes/css/admin-
 bar.css#L271

 {{{
 #wpadminbar .quicklinks .menupop ul li a:hover,
 #wpadminbar .quicklinks .menupop ul li a:focus,
 #wpadminbar .quicklinks .menupop ul li a:hover strong,
 #wpadminbar .quicklinks .menupop ul li a:focus strong,
 #wpadminbar .quicklinks .menupop.hover ul li a:hover,
 #wpadminbar .quicklinks .menupop.hover ul li a:focus,
 #wpadminbar.nojs .quicklinks .menupop:hover ul li a:hover,
 #wpadminbar.nojs .quicklinks .menupop:hover ul li a:focus,
 #wpadminbar li:hover .ab-icon:before,
 #wpadminbar li:hover .ab-item:before,
 #wpadminbar li a:focus .ab-icon:before,
 #wpadminbar li .ab-item:focus:before,
 #wpadminbar li.hover .ab-icon:before,
 #wpadminbar li.hover .ab-item:before,
 #wpadminbar li:hover #adminbarsearch:before,
 #wpadminbar li #adminbarsearch.adminbar-focused:before {
         color: #00b9eb;
 }
 }}}

 @helen: I could definitely use some help with that last part.:)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29906#comment:55>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform