[wp-trac] [WordPress Trac] #30138: Problem of getting the size (width and height) for .ico file

[WordPress Trac]

#30138: Problem of getting the size (width and height) for .ico file
--------------------------+------------------------------
 Reporter:  solidcolour   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Media         |     Version:  4.0
 Severity:  normal        |  Resolution:
 Keywords:  2nd-opinion   |     Focuses:
--------------------------+------------------------------
Changes (by jorbin):

 * keywords:   => 2nd-opinion


Comment:

 Thanks for the report solidcolour.  The issue is that the underlying php
 function `getimagesize` only supports ico files in php 5.3.0.

 I think what core should do in this situation is:

 1) check if IMAGETYPE_ICO is not defined
 2) return false if it is not and we are presented with an ico file
 3) add some documentation around this (and use it as further encouragement
 to get off 5.2)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30138#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform