[wp-trac] [WordPress Trac] #30921: "Cannot Remove Old Plugin" Obliterates files!

[WordPress Trac]

#30921: "Cannot Remove Old Plugin" Obliterates files!
-----------------------------+------------------
 Reporter:  johnstonphilip   |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  4.3
Component:  Upgrade/Install  |     Version:  4.1
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |     Focuses:
-----------------------------+------------------
Changes (by dd32):

 * milestone:  Future Release => 4.3


Comment:

 Lets do something here in 4.3.

 [attachment:30921.diff  30921.diff] performs a
 `$wp_filesystem->is_writable()` check on all files before it attempts to
 run a delete. This applies for Theme/Plugin updates.

 I've tested sparingly by altering a plugin file to be owned by root and
 attempting to update.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30921#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform