[wp-trac] [WordPress Trac] #32110: "Shiny" plugin updates not working when I try run mulitple updates at once and one fails

WordPress Trac noreply at wordpress.org
Mon Jun 15 04:26:22 UTC 2015


#32110: "Shiny" plugin updates not working when I try run mulitple updates at once
and one fails
-----------------------------+--------------------
 Reporter:  magicroundabout  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  4.2.3
Component:  Upgrade/Install  |     Version:  4.2
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+--------------------
Changes (by dd32):

 * keywords:  has-patch needs-testing => has-patch


Comment:

 > I'm not able to reproduce the events shown in the video. Once
 disconnecting my connection and clicking update, I get all spinners with
 no failures.

 This is because `wp.updates.updateError` relies upon the server response
 to know which plugin it's actually operating upon. As a result, if the
 JSON return is malformed (ie. PHP notices) or the connection drops, the
 error handler is unable to report the failure to the UI.

 The other issue at play here is that if an individual plugin update fails,
 the other updates are not canceled, nor continued. The patch here appears
 to fix this, and I see no harm in allowing other updates to continue (even
 if one has failed for some reason).

 The cause for a plugin update failing, could be related to #32198

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32110#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list