[wp-trac] [WordPress Trac] #31661: Quicktags: Can't add them using just a keyboard in IE

WordPress Trac noreply at wordpress.org
Tue Jun 9 01:49:44 UTC 2015


#31661: Quicktags: Can't add them using just a keyboard in IE
----------------------------------+----------------------------------------
 Reporter:  Cheffheid             |       Owner:
     Type:  defect (bug)          |      Status:  new
 Priority:  normal                |   Milestone:  Awaiting Review
Component:  Editor                |     Version:  4.1
 Severity:  normal                |  Resolution:
 Keywords:  has-patch needs-      |     Focuses:  accessibility, javascript
  testing                         |
----------------------------------+----------------------------------------

Comment (by Cheffheid):

 New patch, refreshed against trunk.

 I've also flipped checks around in the callback function on line 502,
 since IE9 and up supports `canvas.selectionStart` anyway and so this way
 `document.selection` is only used for the older browsers that don't.

 Similarly, the OnTab function uses `canvas.selectionStart` first before
 trying `document.selection` to store whatever the value needs to be to add
 the tags.

 I've done some quick tests with keyboard and mouse in IE8, IE9, IE10,
 IE11, Firefox 38, and Chrome 43 and it looks good. As before, need someone
 to confirm and double check for me. :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31661#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list