[wp-trac] [WordPress Trac] #23797: Hard coded HTML marking in comment_form()

WordPress Trac noreply at wordpress.org
Thu Jun 4 19:04:21 UTC 2015


#23797: Hard coded HTML marking in comment_form()
-------------------------+-----------------------------
 Reporter:  Marie-Aude   |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Future Release
Component:  Comments     |     Version:  3.5.1
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+-----------------------------
Changes (by rachelbaker):

 * milestone:  Awaiting Review => Future Release


Comment:

 Can we also keep the `comment-reply-title` class added in
 [https://core.trac.wordpress.org/changeset/24525 24525] to the h3 element?
 I don't see any reason for removing the `id` attribute '''and''' changing
 the `class` attribute.  Before we remove the `id` attribute from the h3 we
 should check and see how many themes are targeting it for styling.

 I would also suggest changing `comment_reply_markup` to be something more
 appropriate, perhaps `comment_reply_title`?

 I am +1 on the overall intent.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23797#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list