[wp-trac] [WordPress Trac] #31655: Cmd+S needs to work in text view of post editor

[WordPress Trac]

#31655: Cmd+S needs to work in text view of post editor
--------------------------+--------------------------------------------
 Reporter:  krogsgard     |       Owner:  azaozz
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  4.3
Component:  Editor        |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  ux-feedback   |     Focuses:  ui, accessibility, javascript
--------------------------+--------------------------------------------
Changes (by johnbillion):

 * keywords:  has-patch => ux-feedback
 * status:  closed => reopened
 * focuses:  ui, javascript => ui, accessibility, javascript
 * resolution:  fixed =>


Comment:

 Replying to [comment:7 iseulde]:
 > I wonder if the user will then expect everything on the page to save. At
 the moment your cursor needs to be in the visual editor to use it and it
 will only save the main fields. Should it work for the whole page, or only
 when the cursor is in one of the editors?
 This is a concern. There's no reason for this only to trigger while focus
 is in the editor, and performing an autosave isn't what I'd expect from
 cmd+S (although #7756 would address this in the longer term).

 TIL that cmd/ctrl+S was quietly introduced for autosave in the editor back
 in #24067.

 cmd+S should perform a complete save, and should trigger regardless of
 where the focus is on the page.

 Tagging accessibility because I know that custom keyboard shortcuts
 potentially have an accessibility impact.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31655#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform