[wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters

[WordPress Trac]

#30377: wp_check_filetype is broken when checking urls with parameters
-------------------------------------------------+-------------------------
 Reporter:  supercleanse                         |       Owner:
     Type:  defect (bug)                         |  wonderboymusic
 Priority:  normal                               |      Status:  reopened
Component:  Media                                |   Milestone:  Future
 Severity:  normal                               |  Release
 Keywords:  has-patch needs-testing needs-unit-  |     Version:  4.0
  tests                                          |  Resolution:
                                                 |     Focuses:
-------------------------------------------------+-------------------------
Changes (by johnbillion):

 * keywords:  has-patch needs-testing needs-refresh => has-patch needs-
     testing needs-unit-tests


Comment:

 The problem here is that `wp_check_filetype()` was never intended to work
 with URLs, only file paths.

 If we're going to explicitly allow support for URLs (which we need to do
 by extension of the fact that this function is used in the
 `wp_[audio|video|playlist]_shortcode()` functions), this is gonna need
 unit test coverage and security review.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30377#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform