[wp-trac] [WordPress Trac] #33193: The global, $is_IE, doesn't properly detect Microsoft Edge

[WordPress Trac]

#33193: The global, $is_IE, doesn't properly detect Microsoft Edge
--------------------------+------------------------------
 Reporter:  gregrickaby   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------

Comment (by gregrickaby):

 With all due respect, the very reason for this patch ''was'' to help
 target Microsoft Edge on a current project of mine.

 I needed to fix an overflow bug: {{{-ms-overflow-style: none;}}}

 New rendering engine(s) or not, people (e.g., front-end devs like me) will
 still need to target M$FT browsers. I'm for anything that makes this
 process easiest; just know, the current global returns true for $is_chrome
 (when it's clearly not). That's not in the best interest of anyone!

 As an aside: this entire file needs to be overhauled. No yoda
 conditionals, endless if/else/else ifs, etc. Maybe a PHP switch is in
 order? This one does it pretty well:
 https://github.com/cbschuld/Browser.php/blob/master/lib/Browser.php

 Thanks for hearing me out @dd32 and I'm happy to help...

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33193#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform