[wp-trac] [WordPress Trac] #33031: Fix accessibility for the Keyboard Shortcuts help dialog

[WordPress Trac]

#33031: Fix accessibility for the Keyboard Shortcuts help dialog
--------------------------+----------------------------
 Reporter:  azaozz        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.3
Component:  TinyMCE       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  accessibility
--------------------------+----------------------------
Changes (by azaozz):

 * milestone:  Awaiting Review => 4.3


Comment:

 > ...when focus is on the Close button users can't move focus back and
 scroll the content

 Adding `role="tab"` to the scrollable wrapper seems to fix this. Not sure
 if that breaks something else for screen readers.

 > symbols like `* - > #` get announced in a weird way or they don't get
 announced at all

 Hmm, thought screen readers would "understand" the `<kbd>` tag, seems they
 don't... Would it help if we wrap these in a `<code>` (although
 semantically `<kbd>` is the proper tag there). Is there anything other we
 can add to make screen readers "read" these? Perhaps some aria attr?

 We can also add spans with screen-reader-text, not sure if that won't make
 it messier.

 Going to commit it with the above changes so it can be tested easier.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33031#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform