[wp-trac] [WordPress Trac] #15694: Shortcode I/O Intolerant of "]", "<", Quotes, etc.

[WordPress Trac]

#15694: Shortcode I/O Intolerant of "]", "<", Quotes, etc.
------------------------------------------+-----------------------------
 Reporter:  miqrogroove                   |       Owner:  miqrogroove
     Type:  defect (bug)                  |      Status:  assigned
 Priority:  high                          |   Milestone:  Future Release
Component:  Shortcodes                    |     Version:  3.0.1
 Severity:  normal                        |  Resolution:
 Keywords:  needs-patch needs-unit-tests  |     Focuses:  javascript
------------------------------------------+-----------------------------

Comment (by jadpm):

 Not sure this is the right place or even moment, but this change, which
 just landed 33 hours ago in the 4.2 branch and was released with the
 latest 4.2.3 is causing a '''massive''' chain of problems.

 I work on a company which products rely a lot on shortcodes, and suddenly
 all shortcodes used as HTML attributes have stopped working. We are
 experiencing a huge impact in our support forum and clients are blaming us
 for not being ready... to test a change that landed just hours before
 being released. Not fair IMHO.

 You can see also some very nice bug reports on products that are not our
 own, here:
 https://wordpress.org/support/topic/wordpress-423-broke-my-code
 https://wordpress.org/support/topic/no-buttons-to-see-after-update-wp-423

 A simple test case:
 - create a shortcode that returns an image URL
 - add that shortcode as a background-image utl value on a style attribute
 - pull your hair when visiting the frontend

 This used to work perfectly fine in 4.2.2 and before. So I do wonder how
 this can happen. I am attaching a test case with a dummy shortcode (really
 dummy) and two test cases, with a very nasty result.

 Please review this and provide a fix or a revert to a previous state until
 this gets a proper fix.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/15694#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform