[wp-trac] [WordPress Trac] #33031: Fix accessibility for the Keyboard Shortcuts help dialog

[WordPress Trac]

#33031: Fix accessibility for the Keyboard Shortcuts help dialog
--------------------------+------------------------------
 Reporter:  azaozz        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  TinyMCE       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  accessibility
--------------------------+------------------------------

Comment (by afercia):

 Tested a bit the patch and yes it improves things a bit. There's still a
 big issue though. Had a look at what `'tinymce.ui.KeyboardNavigation'`
 does for TinyMCE "containers" and it tries to implement some sort of
 proprietary focus management. So what happens that impact accessibility?
 As soon as you press Tab or the Down Arrow key, as screen reader users
 normally do to read content, focus is moved to the Close "button" and
 can't be moved further. You're basically "trapped" on the Close button.

 `'tinymce.ui.KeyboardNavigation'` works (more or less) for TinyMCE dialogs
 that contain TinyMCE controls or what TinyMCE considers focusable elements
 which are `input, textarea` and elements with an ARIA role of
 `button|menuitem|checkbox|tab|menuitemcheckbox|option|gridcell`.
 It's something tied to what TinyMCE needs, but I fear it's not what we
 need here.

 To my understanding, if we still want to use a TinyMCE modal dialog, we
 should basically remove the TinyMCE focus management and implement our
 own. This would mean we should rebuild many things inside this modal. Does
 it worth it? Wouldn't be easier to just don't use a TinyMCE modal dialog
 in the first place?

 For an example of what should be removed and rebuilt in order to have a
 decent level of accessibility, see the attached patch. That's not to say
 we should do this :) It's basically hacking TinyMCE, with all the implied
 consequences, and maintenance issues.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33031#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform