[wp-trac] [WordPress Trac] #33021: Global javascript variables incorrectly defined

WordPress Trac noreply at wordpress.org
Sun Jul 19 16:10:06 UTC 2015


#33021: Global javascript variables incorrectly defined
------------------------------+------------------------------
 Reporter:  johnjamesjacoby   |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch close   |     Focuses:  javascript
------------------------------+------------------------------
Changes (by jorbin):

 * keywords:  has-patch => has-patch close


Comment:

 If An IDE has bugs in it's jshint implementation, then the bug report
 should be filed with them. Making changes to match a spec is a trip down a
 rabbit hole.  As the [https://make.wordpress.org/core/handbook/best-
 practices/coding-standards/javascript/#code-refactoring Javscript Coding
 standards] specifically state:

 > While the coding standards are important, refactoring older .js files
 simply to conform to the standards is not an urgent issue. “Whitespace-
 only” patches for older files are strongly discouraged.

 I think this should be closed maybelater.  When the lines are touched for
 a substantial reason, we should fix them up.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33021#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list