[wp-trac] [WordPress Trac] #32687: Customizer Menus: Complete PHPUnit tests
WordPress Trac
noreply at wordpress.org
Sat Jul 18 21:05:56 UTC 2015
#32687: Customizer Menus: Complete PHPUnit tests
------------------------------+---------------------------
Reporter: designsimply | Owner: valendesigns
Type: task (blessed) | Status: assigned
Priority: high | Milestone: 4.3
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch commit | Focuses:
------------------------------+---------------------------
Comment (by valendesigns):
I'm thinking that we should make a small adjustment to
`load_available_items_query` before it's committed, so the hooks API is
easier to create. Basically what I did in [attachment:32687.6.diff] was
remove the assertion & WP_Error that forced `$obj_type` to be `post_type`
or `taxonomy`, which allows us to add alternative custom object types in a
separate patch in #32708 which I'm refreshing now. This new hook would be
in an else statement at the end of the function and filter the available
`$items` for that custom object type. This way we're not held back by an
arbitrary requirement that the object type be `post_type` or `taxonomy`
which makes zero sense for extensibility purposes.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/32687#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list