[wp-trac] [WordPress Trac] #32810: Customizer Menus: Indicate when there are no items
WordPress Trac
noreply at wordpress.org
Sat Jul 18 19:10:44 UTC 2015
#32810: Customizer Menus: Indicate when there are no items
------------------------------+-------------------------------
Reporter: swissspidy | Owner: celloexpressions
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.3
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch commit | Focuses: ui, javascript
------------------------------+-------------------------------
Changes (by valendesigns):
* keywords: has-patch => has-patch commit
Comment:
@celloexpressions I like the direction of your patch, it's a much simpler
solution. Although there were a couple changes I made to it in
[attachment:32810.5.diff]. The transparent background was odd when there
is a open section below or above, so I think it's best to just use the
default white background for the time being. That is until we get the
chance to go over the UI again in 4.4. Additionally, using absolute
position could bite us later with long translation strings and so I
modified it to use float. Which meant I needed to hide the spinner
completely and remove its ghost, that allowed the text to fully float
right. Last, I added a negative tab index on the button so it would be
skipped and not focusable. I think this is ready to go if you can live
with the white background.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/32810#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list