[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General

[WordPress Trac]

#16434: Give site admin ability to upload favicon in Settings, General
--------------------------+------------------------------------------------
 Reporter:  jane          |       Owner:  obenland
     Type:  task          |      Status:  reopened
  (blessed)               |   Milestone:  4.3
 Priority:  normal        |     Version:  3.1
Component:  Customize     |  Resolution:
 Severity:  normal        |     Focuses:  ui, accessibility, administration
 Keywords:  has-patch     |
--------------------------+------------------------------------------------

Comment (by DrewAPicture):

 Just tested [attachment:16434.24.diff] at @obenland's request. I'm coming
 into this blind as I had never used this UI before, which I suppose might
 be to our benefit.

 Overall, the cropping UI looks good on mobile and desktop and seems
 intuitive and easy to figure out. I came across a couple of things in the
 Customizer control UI that seem like they could still be fine-tuned:

 1. If I crop an image, set it as the icon, and Save & Publish, then I
 remove the image and try to set it again, it's not listed in the media
 modal. I'm guessing this is because we didn't refresh the media list. I
 would've expected the newly-cropped image to be available right away, I
 just cropped it a minute ago ... :)

 2. I wonder if Chrome on Mac is the best choice for a browser icon
 previewer for 80 percent of our users.

 3. After refreshing the page, the newly-cropped image(s) now show up in
 the media modal as expected. However, I also now have a new button,
 "Default", that apparently restores the default that I don't remember
 setting (because I didn't). I don't think it's really clear how the
 "default" icon is determined, this is probably because it seems like that
 should be a deliberate action made by the user or the theme author – in
 which case, I'd expect there to be some kind of visual indication of the
 default choice.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/16434#comment:247>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform