[wp-trac] [WordPress Trac] #33001: Customizer loads wp-a11y.js multiple times
WordPress Trac
noreply at wordpress.org
Fri Jul 17 22:26:09 UTC 2015
#33001: Customizer loads wp-a11y.js multiple times
----------------------------------+----------------------------------------
Reporter: afercia | Owner: westonruter
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 4.3
Component: Customize | Version: 4.2
Severity: normal | Resolution:
Keywords: has-patch needs- | Focuses: accessibility, javascript
testing |
----------------------------------+----------------------------------------
Changes (by westonruter):
* keywords: needs-patch => has-patch needs-testing
Comment:
@afercia: Good point on changing the script dependencies. There's no need
for `wp.a11y` in the Customizer preview, so we can make `wp-a11y` a
dependency of `customize-controls`, which is the shared dependency of
`customize-widgets` and `customize-nav-menus` which are the two scripts
that actually use this `wp.a11y`. I think it makes sense for the
dependency to be added to `customize-controls` as opposed to those
dependent scripts because `wp.a11y` will surely be used more in the core
Customizer going forward. See [attachment:33001.diff] and if good, add the
`commit` keyword.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/33001#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list