[wp-trac] [WordPress Trac] #32165: wp-db.php destructs all the multibyte characters

[WordPress Trac]

#32165: wp-db.php destructs all the multibyte characters
--------------------------+-----------------------
 Reporter:  kjmtsh        |       Owner:  pento
     Type:  defect (bug)  |      Status:  reopened
 Priority:  high          |   Milestone:  4.2.3
Component:  Database      |     Version:  4.1.2
 Severity:  blocker       |  Resolution:
 Keywords:                |     Focuses:
--------------------------+-----------------------

Comment (by pento):

 [attachment:32165.3.diff] is the first pass at solving the second problem
 described in comment:36.

 To provide some context - the functionality to switch character sets was
 added because of some edge cases we found of queries doing strange things
 with mixed character sets. In the process, however, I suspect we lost
 sight of the woods for all of the trees, breaking the much more common and
 legitimate use case of simply taking non-utf8 strings from user input, and
 allowing MySQL to convert them to utf8.

 I think it's reasonable for us to remove this (it was a little ridiculous
 of us to allow for changing character sets in a single query).

 @nacin, @mdawaffe, @nbachiyski: As my co-conspirators on this
 functionality, your thoughts would be greatly appreciated (in the next day
 or two, please - this needs to be fixed in 4.2.3).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32165#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform