[wp-trac] [WordPress Trac] #32715: Menu Customizer: UI controls without text

[WordPress Trac]

#32715: Menu Customizer: UI controls without text
--------------------------+----------------------------------------
 Reporter:  afercia       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.3
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  accessibility, javascript
--------------------------+----------------------------------------
Changes (by afercia):

 * keywords:  has-patch needs-refresh => has-patch


Comment:

 Updated patch. As pointed out in Slack, see
 https://wordpress.slack.com/archives/core-customize/p1436835284000563,
 this requires to patch `accordion.js`.
 We should try to be HTML agnostic and detect if there's any element
 intended to act as a specific toggle control. I'd say to just look for the
 first element with `aria-expanded`. Open to suggestions.

 In `customize-nav-menus.js` tried to store some elements to avoid getting
 them multiple times.

 Reworked the arrow indicator. TL;DR noticed a weird bug in NVDA: it didn't
 announce "expanded/collapsed". Turned out it was caused by the CSS
 generated dashicon which is currently overlaid on the button, see
 screenwhot:

 [[Image(https://cldup.com/_oD0VKRXzU.png)]]

 When its content changes from `\f140` to `\f142` NVDA gets someway
 confused and doesn't announce the "expanded/collapsed" aria attribute
 change of the underlying button. Tried several things and ended up putting
 the arrow inside the button in a `span` with `role=presentation`. No
 visual changes.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32715#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform