[wp-trac] [WordPress Trac] #32222: Silent error on attempt of user creation

[WordPress Trac]

#32222: Silent error on attempt of user creation
--------------------------------------+------------------------------
 Reporter:  psycleuk                  |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Database                  |     Version:  4.2.1
 Severity:  normal                    |  Resolution:
 Keywords:  needs-patch dev-feedback  |     Focuses:
--------------------------------------+------------------------------
Changes (by ruud@…):

 * keywords:  needs-patch => needs-patch dev-feedback


Comment:

 Did some further digging into the user_nicename usage.. in the
 wp_insert_user() function this gets more complicated because the code is
 also actively checking for the uniqueness of the user_nicename string..
 and suffixing it when not.
 In the case the user_nicename would be empty this code would then result
 in user_nicename values of '-2', '-3' and so forth..
 This doesn't scale very well.
 Another aspect: a user_nicename length could be exactly 50 (and in use..),
 resulting in a user_nicename with suffix, and subsequently a failed
 database insert action because the new string is larger then the column
 allows.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32222#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform