[wp-trac] [WordPress Trac] #32847: Remove 'error' parameter in wp_admin_canonical_url()

[WordPress Trac]

#32847: Remove 'error' parameter in wp_admin_canonical_url()
----------------------------+-----------------------------
 Reporter:  jdgrimes        |       Owner:
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  Future Release
Component:  Administration  |     Version:  4.2
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:  administration
----------------------------+-----------------------------
Changes (by jdgrimes):

 * keywords:  needs-patch reporter-feedback => needs-patch


Comment:

 Replying to [comment:1 johnbillion]:
 > When/where is `error` used on the themes screen? I can't seem to see it.

 I just realized that it was `/network/themes.php`.
 [https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/network/themes.php#L294 See lines 294-6]. Also on `/network/site-
 themes.php` [https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/network/site-themes.php#L177 line 177].

 I just noticed that `site-themes.php`
 [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/network/site-
 themes.php#L42 cleans the URI] though.
 [https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/network/themes.php#L26 So does] `/network/themes.php`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32847#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform