[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General

[WordPress Trac]

#16434: Give site admin ability to upload favicon in Settings, General
--------------------------+------------------------------------------------
 Reporter:  jane          |       Owner:  obenland
     Type:  task          |      Status:  accepted
  (blessed)               |   Milestone:  4.3
 Priority:  normal        |     Version:  3.1
Component:  Customize     |  Resolution:
 Severity:  normal        |     Focuses:  ui, accessibility, administration
 Keywords:  ux-feedback   |
  has-patch               |
--------------------------+------------------------------------------------

Comment (by ocean90):

 [attachment:16434.15.diff]:
 * `$( 'link[rel="icon"]' ).attr( 'href', attachment.sizes.thumbnail.url );
 ` won't work if you haven't set a site icon before because
 `wp_site_icon()` doesn't print anything if ` ! has_site_icon()`.
 * The media frame gets a sidebar after an image has been set and you open
 frame again, see https://cloudup.com/c3lzgA0TRNn. The button label is
 missing too.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/16434#comment:221>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform