[wp-trac] [WordPress Trac] #31168: Comments should be turned off on pages by default
WordPress Trac
noreply at wordpress.org
Wed Jul 8 03:03:51 UTC 2015
#31168: Comments should be turned off on pages by default
-------------------------------------+---------------------------
Reporter: melchoyce | Owner: valendesigns
Type: enhancement | Status: closed
Priority: normal | Milestone: 4.3
Component: Comments | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch needs-testing | Focuses:
-------------------------------------+---------------------------
Changes (by nacin):
* status: reopened => closed
* resolution: => fixed
Comment:
Re-closing as now I see that this thought process was already laid out
above, initially by @helen (and changed in [33054]), and I just missed it.
This probably does belong in the handbook somewhere if anyone wants to
take a swing. :-)
A few more thoughts on when to avoid dynamic hook names:
* When the static part of the dynamic hooks is so generically named that
it can conflict with other dynamic (or static) hooks. This is a huge
problem with some older hooks, but we're more wordy these days. (Not a
major problem on this one.)
* As @helen said, it can be harder to find the hook, and also harder to
take an `add_filter()` call in code you're reading and understand exactly
what the actual filter is. (This could be a cool reverse-engineering tool
to write...)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/31168#comment:57>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list