[wp-trac] [WordPress Trac] #32351: sanitize_option desperately needs unit tests

[WordPress Trac]

#32351: sanitize_option desperately needs unit tests
------------------------------------+--------------------------
 Reporter:  chriscct7               |       Owner:  johnbillion
     Type:  defect (bug)            |      Status:  closed
 Priority:  normal                  |   Milestone:  4.3
Component:  Formatting              |     Version:
 Severity:  normal                  |  Resolution:  fixed
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+--------------------------
Changes (by johnbillion):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 Tests are in. As per
 [https://core.trac.wordpress.org/ticket/32351#comment:11 my comment
 above], I'm still concerned that these tests don't actually cover funky
 behaviour of `$wpdb->strip_invalid_text_for_column()`.

 I'll open a follow-up ticket for improvements to `Tests_DB_Charset`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32351#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform