[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General

[WordPress Trac]

#16434: Give site admin ability to upload favicon in Settings, General
--------------------------+------------------------------------------------
 Reporter:  jane          |       Owner:  obenland
     Type:  task          |      Status:  accepted
  (blessed)               |   Milestone:  4.3
 Priority:  normal        |     Version:  3.1
Component:  Customize     |  Resolution:
 Severity:  normal        |     Focuses:  ui, accessibility, administration
 Keywords:  ux-feedback   |
  has-patch               |
--------------------------+------------------------------------------------

Comment (by lucaspiller):

 Replying to [comment:218 obenland]:
 > If there is no site icon set, what would you need to filter the output
 for?
 >
 > Tp provide compatibility with existing solutions you could filter the
 site icon option and provide a custom attachment id as a default if the
 option is empty.

 The plugin lets you specify different favicon attachments for each type
 (e.g. ico, png, apple touch, metro, etc). In this case I'm not really
 filtering, but just using the filter to hook into the code which renders
 the favicons at the right time. In the method called by the filter I
 replace $meta_tags with my own tags, which refer to each attachment the
 user specifies.

 Hooking into the site icon option would work, but it's still a bit messy
 as I'm just adding something to work around the flexibility issue - it's
 not actually used. I think a better solution in my case is to completely
 remove the wp_site_icon action and role my own. Thanks for the rubber duck
 debugging!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/16434#comment:219>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform