[wp-trac] [WordPress Trac] #32841: Partial refresh <div> in menu customizer breaks some theme designs

[WordPress Trac]

#32841: Partial refresh <div> in menu customizer breaks some theme designs
-------------------------------------+--------------------------
 Reporter:  greenshady               |       Owner:  westonruter
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  4.3
Component:  Customize                |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  javascript
-------------------------------------+--------------------------
Changes (by westonruter):

 * keywords:  has-patch => has-patch needs-testing


Comment:

 Replying to [comment:9 greenshady]:
 > Gotcha.  Yes, that sounds good.  I'd probably need access to the old
 container.

 Thanks. Could you give [attachment:32841.4.diff] a spin with your theme?

 To summarize the changes in the patch:

 * Remove additional wrapper around `wp_nav_menu()`'s normal menu
 container, replacing nav menu
 * Send `newContainer` and `oldContainer` in params sent via the
 `customize-preview-menu-refreshed` event.
 * Fix partial refresh for custom menu widget (which was failing due to a
 hash mismatch).
 * Harden partial refresh, ensuring a full preview refresh is done when all
 of the necessary conditions are met.
 * Improve performance of partial refresh by only sending settings that are
 relevant to the given menu.
 * Refresh the preview when a partial refresh response returns no data, as
 this means the menu is no longer assigned to the location and the page may
 need to be reflowed.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32841#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform