[wp-trac] [WordPress Trac] #31620: get_raw_theme_root does not resolve custom theme folder when is the unique

[WordPress Trac]

#31620: get_raw_theme_root does not resolve custom theme folder when is the unique
-------------------------------------+------------------------------
 Reporter:  giuseppe.mazzapica       |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Themes                   |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+------------------------------

Comment (by giuseppe.mazzapica):

 Replying to [comment:10 McGuive7]:
 > One other concern, and this may be a non-issue however I'd love to get a
 2nd opinion. It has to do with this line of code:
 > {{{
 > return strpos( $theme_path_normalized, $content_path_normalized ) === 0
 ? substr( $theme_path_normalized, strlen( $content_path_normalized ) ) :
 $theme_path_normalized;
 > }}}
 > [...]


 The conditional is a bit odd, I know, but is required according to #17597
 (that was mentioned in OP).

 If you read till the end, you'll see that with [20016] has been introduced
 a change that (quoting @nacin in ticket:17597#comment:12)

 > Fix the return value of get_theme_root() when the theme root is outside
 of WP_CONTENT_DIR, thus making it absolute rather than the typical
 relative theme root.
 >
 > Make get_theme_root_uri() tolerate an absolute path for a theme root. It
 will now make an attempt to find a corresponding URL for absolute paths as
 well.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31620#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform