[wp-trac] [WordPress Trac] #32154: Don't upgrade global tables for utf8mb4

[WordPress Trac]

#32154: Don't upgrade global tables for utf8mb4
--------------------------+-----------------------
 Reporter:  ocean90       |       Owner:  dd32
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  4.2.3
Component:  Database      |     Version:  4.2
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------

Comment (by johnjamesjacoby):

 Thanks for getting this in, Dion. A few thoughts:

 * Is `wp_should` a convention we want to continue to use? I picked `can`
 since it matches existing nomenclature, and arguably WordPress should
 upgrade all tables all the time, but currently cannot for x/y/z reasons.
 * Why remove the `(bool)` type cast? I think it's better to be explicit
 after filters are applied, to ensure strict comparisons don't produce
 undesirable results, especially with something sensitive like this.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32154#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform