[wp-trac] [WordPress Trac] #30902: Create new dashicons (4.3)

WordPress Trac noreply at wordpress.org
Thu Jul 2 16:38:00 UTC 2015


#30902: Create new dashicons (4.3)
----------------------------+---------------------------------
 Reporter:  EmpireOfLight   |       Owner:  melchoyce
     Type:  task (blessed)  |      Status:  assigned
 Priority:  normal          |   Milestone:  4.3
Component:  Administration  |     Version:  4.1
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:  ui, administration
----------------------------+---------------------------------

Comment (by melchoyce):

 Seeing a typo in the patch:

 {{{
 .dashicons-layout:before {
 content: "\ff538";
 }
 }}}

 The second "f" should be removed.

 Do you know if `.dashicons-exerpt-view:before, /* Misspelled. Use
 .dashicons-excerpt-view instead. */` was intentionally removed? We should
 ideally deprecate that eventually, but I figured we'd do that kind of
 cleanup when we move over to SVG.

 `.dashicons-admin-filter` should probably just be `.dashicons-filter`
 since it's not specifically going into the admin menu.

 Likewise, `.dashicons-lock-unlock` should probably just be `.dashicons-
 unlock`.

 Sorry, should have caught these earlier. Do you want me to edit your
 patch, or do you have time to revisit it today? I don't want to take up
 too much of your time.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30902#comment:51>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list