[wp-trac] [WordPress Trac] #31950: Reduce PHP memory usage / No unnecessary concatenation

[WordPress Trac]

#31950: Reduce PHP memory usage / No unnecessary concatenation
-----------------------------------------+------------------------------
 Reporter:  jrf                          |       Owner:
     Type:  enhancement                  |      Status:  new
 Priority:  normal                       |   Milestone:  Awaiting Review
Component:  General                      |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch 2nd-opinion close  |     Focuses:  performance
-----------------------------------------+------------------------------
Changes (by jorbin):

 * keywords:  has-patch 2nd-opinion => has-patch 2nd-opinion close


Comment:

 I agree with Dion that this is at best a microoptimization.  I don't think
 it is worth the code churn.  Even the benchmarks above show that this
 isn't even garunteed to improve performance across all PHP versions we
 support (the usertime for HHVM, 5.2, 5.3, and 7.0 is higher not using
 concatenation ). I think this is a case where practicality trumps
 theoretical correctness.

 Suggest closing as wontfix.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31950#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform