[wp-trac] [WordPress Trac] #31168: Comments should be turned off on pages by default

[WordPress Trac]

#31168: Comments should be turned off on pages by default
-------------------------------------+---------------------------
 Reporter:  melchoyce                |       Owner:  valendesigns
     Type:  enhancement              |      Status:  reopened
 Priority:  normal                   |   Milestone:  4.3
Component:  Comments                 |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  needs-patch 2nd-opinion  |     Focuses:
-------------------------------------+---------------------------

Comment (by obenland):

 Replying to [comment:46 helen]:
 > I noticed that the hook ended up with a dynamic name:
 `get_{$post_type}_default_comment_status`. Dynamic hooks are neat, but not
 always easy to find, and there's usually a case to be made for the generic
 non-dynamic version. I think it'd be better to go with
 `get_default_comment_status` and pass the post type as context.

 I was actually thinking about that in my final review. I think we should
 definitely do that.

 > Also, do we need to do a general audit of `get_option(
 'default_comment_status' )` uses?
 Yes we do.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31168#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform