[wp-trac] [WordPress Trac] #31590: Comment reply links can cause JS error on slow connections/large pages

[WordPress Trac]

#31590: Comment reply links can cause JS error on slow connections/large pages
---------------------------+-----------------------------------
 Reporter:  peterwilsoncc  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Comments       |     Version:  2.7
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  javascript, template
---------------------------+-----------------------------------

Comment (by peterwilsoncc):

 Replying to [comment:8 markjaquith]:
 > Is there a certain amount of time in which we should just go through
 with it, if the code launches?

 31590.1.diff builds on the saving mechanism in the original patch by
 adding an expiring method queue. 500ms seems as suitable response/expiry
 time as any. ¯\_(ツ)_/¯

 31590.1.diff maintains the obtrusive JavaScript approach. As I mentioned
 above, it works but is sub-optimal.

 -

 I would prefer to go down the unobtrusive path as in the plugin.
 Technically the plugin works as is but it needs a tidy-up, moveForm needs
 to be refactored. Cutting the mustard check in the plugin makes it IE9+
 only at present, it relies on the query-string fallback for older
 browsers.

 Should it be determined that comment replies are an enhancement, then I'd
 take the approach of an empty `span` with data attributes to be replaced
 with a link once comment-reply runs.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31590#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform