[wp-trac] [WordPress Trac] #11334: Add caching to get_page_of_comment()

[WordPress Trac]

#11334: Add caching to get_page_of_comment()
--------------------------+--------------------------
 Reporter:  Viper007Bond  |       Owner:
     Type:  enhancement   |      Status:  new
 Priority:  high          |   Milestone:  4.2
Component:  Comments      |     Version:  2.9
 Severity:  major         |  Resolution:
 Keywords:  has-patch     |     Focuses:  performance
--------------------------+--------------------------
Changes (by boonebgorges):

 * keywords:  has-patch 4.0-early needs-testing => has-patch
 * focuses:   => performance
 * milestone:  Future Release => 4.2


Comment:

 [attachment:11334.3.diff] cleans up the patch and adds caching-specific
 unit tests.

 Critically, the patch also changes older-comment-count caching so that
 it's comment-specific rather than post-specific. If we cache on a post-by-
 post basis, then every comment associated with that post will return the
 same value for `get_page_of_comment()`, which is clearly wrong. Can I get
 a sanity check on that? :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/11334#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform