[wp-trac] [WordPress Trac] #31086: Uniform results for getting terms

[WordPress Trac]

#31086: Uniform results for getting terms
--------------------------+--------------------
 Reporter:  joshlevinson  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.2
Component:  Taxonomy      |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  dev-feedback  |     Focuses:
--------------------------+--------------------
Changes (by joshlevinson):

 * keywords:  needs-patch needs-unit-tests => dev-feedback


Comment:

 Finally got around to doing this.
 `31086.diff` takes care of the indexing where it occurs, as suggested.
 In order to ensure the results are truly equal, a modification to
 `get_the_terms` was also required (passing in `all_with_object_id` to the
 `fields` parameter, since `update_term_cache` does this).
 I also wrote a unit test, though it's my first so I'm sure it could use
 review for both convention and logic.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31086#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform