[wp-trac] [WordPress Trac] #28272: Image loses link after drag and drop

[WordPress Trac]

#28272: Image loses link after drag and drop
--------------------------+-------------------------
 Reporter:  iseulde       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.2
Component:  TinyMCE       |     Version:
 Severity:  major         |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+-------------------------

Comment (by valendesigns):

 @iseulde That makes sense, thank you for the clarification on the pull
 request and `Quirks.js`. I've closed the PR since you've pointed out there
 is a file which already exists where we can solve this issue in the Core.
 However, your patch doesn't fix moving captions. It will move the captions
 content, but not the actual caption itself. So this does not fix #28003,
 and if we're going to solve captions we should do it in that ticket. IMHO
 We need to solve images inside anchors first.

 I added [attachment:28272.1.diff] that changes a few things from your
 patch like bring back the code that prevented moving images in captions
 (now inside the function), added code for those rare instances where there
 is a wrapping node like `strong` or `em`, and also added checks to make
 sure the parent anchor doesn't have text content. As well, I've renamed
 the function to `selectImageParent` and moved it up with the rest of the
 image functions earlier in the file.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28272#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform