[wp-trac] [WordPress Trac] #31080: GUID should not always be escaped for url in feeds

WordPress Trac noreply at wordpress.org
Sun Jan 25 19:16:41 UTC 2015

#31080: GUID should not always be escaped for url in feeds
 Reporter:  CheeseDurger                         |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Feeds                                |  Review
 Severity:  normal                               |     Version:  trunk
 Keywords:  2nd-opinion needs-patch dev-         |  Resolution:
  feedback                                       |     Focuses:  template
Changes (by stevenkword):

 * keywords:   => 2nd-opinion needs-patch dev-feedback


 The RSS 2.0 spec supports non-URL GUIDs if the `isPermaLink` attribute is
 set as false (defaults to 'true').  The RSS 2.0 template included in core
 does both support this GUID field as well as specifies the isPermaLink
 attribute as false.  So far so good.

 Further investigation into `the_guid` method found in `wp-includes/post-
 template.php` shows that the method simply escapes the URL and prints the
 value.  This seems incorrect to me as well.

 I would like to propose removing the URL escaping from this function, as
 non-URL GUIDs are both valid and a common use case for non-WordPress to
 WordPress migrations.  However, I would like to get a 2nd opinion to
 discuss how this change might break other functionality / use-cases.

 Related: http://www.w3schools.com/rss/rss_tag_guid.asp

Ticket URL: <https://core.trac.wordpress.org/ticket/31080#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list