[wp-trac] [WordPress Trac] #31119: `add_option()` with `$autoload = false` adds option with autoload of "yes"

[WordPress Trac]

#31119: `add_option()` with `$autoload = false` adds option with autoload of "yes"
--------------------------------+------------------
 Reporter:  dlh                 |       Owner:
     Type:  defect (bug)        |      Status:  new
 Priority:  normal              |   Milestone:  4.2
Component:  Options, Meta APIs  |     Version:  4.1
 Severity:  normal              |  Resolution:
 Keywords:  has-patch commit    |     Focuses:
--------------------------------+------------------

Comment (by nacin):

 One of the first things I ever worked on in WordPress core was #10788.
 This is where this originates, and yeah, I didn't do it right.

 I'm going to re-jigger the unit test a bit to use a data provider (and
 avoid `rand_str()`). Please take a look as this is the preferred approach
 for writing tests of this nature, and that way the next time you submit a
 perfect bug report, and a perfect patch, it'll come with perfect tests,
 too. :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31119#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform