[wp-trac] [WordPress Trac] #29974: Focus handle at wrong place when you click reply

[WordPress Trac]

#29974: Focus handle at wrong place when you click reply
----------------------------------+----------------------------------------
 Reporter:  nhuja                 |       Owner:
     Type:  defect (bug)          |      Status:  reopened
 Priority:  normal                |   Milestone:  Awaiting Review
Component:  Comments              |     Version:  2.7
 Severity:  normal                |  Resolution:
 Keywords:  has-patch dev-        |     Focuses:  accessibility, javascript
  feedback                        |
----------------------------------+----------------------------------------

Comment (by afercia):

 Replying to [comment:22 SergeyBiryukov]:
 > With the `aria-label` attribute, does "Logged in as" still need to be a
 part of the link?
 It's a bit tricky, basically screen readers should report as link text
 just the aria-label and ignore the actual text. Tested in Firefox + NVDA:

 [[Image(https://cldup.com/hIXwnKF9QP.png)]]

 That's also how r29822 is intended to work.

 Moving out "Logged in as" would make screen readers read out:
 > Logged in as
 > link
 > Logged in as Andrea. Edit your profile.

 At this point we should hide "Logged in as" from screen readers, something
 like:

 {{{
 <span aria-hidden="true">Logged in as</span>
 <a href="%1$s" aria-label="Logged in as %2$s. Edit your
 profile.">%2$s.</a> <a href="%3$s">Log out?</a>
 }}}

 And that string would be even more problematic. I agree it's
 counterintuitive but that's because I didn't want to make any visual
 change. It would be nice to simplify all this, if there's consensus for a
 small visual change:


 {{{
 Logged in as Andrea. <a ...>Edit your profile.</a> <a ...>Log out?</a>
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29974#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform